Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

Changes in the home page, footer and signup successful page #367

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

Changes in the home page, footer and signup successful page #367

wants to merge 3 commits into from

Conversation

sreyasukavasi3
Copy link

Prevented the overlapping of icons on the home page. - 763cd15
Prevented the footer to go up when there is no content in the page. - fdb8060
Adjusted the signup successful page in registration. - bf7cfa2

@Aniketh01
Copy link
Member

Why is the PR commit message/title like this?
Please make sure you name the PR rightfully according to the issue that you wish to solve.
I see various other commits too after the PR was initiated. Are these relevant to the PR that you opened? If then, make sure you merge all together and open up a single commit.

@chirathr
Copy link
Collaborator

@sreyasukavasi3 Please provide some screenshot for your changes.

@sreyasukavasi3 sreyasukavasi3 changed the title Development Changes in the home page, footer and signup successful page Sep 16, 2018
@sreyasukavasi3
Copy link
Author

commit 8a7a2b91080ff6c09611dff89cd5b047b340c3ef

1

Changed to

issue

@rammanoj
Copy link
Collaborator

rammanoj commented Sep 17, 2018

Prevented the footer to go up when there is no content in the page. - fdb80601
I guess this is not the correct way to do this. You just increased the margin-top this may sometimes create a lot of space in between if there is no content. Changing it would be better. @sreyasukavasi3 can you also put some screenshots regarding the signup successful page?
And I am still able to reproduce this issue
amfoss code share grow - mozilla firefox_005

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants